Skip to content

[VL] Re-enable some decimal tests #12287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhztheplayer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[VL] Re-enable some decimal tests #12287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("SPARK-35719: cast timestamp with local time zone to timestamp without timezone")
// Revised by setting timezone through config and commented unsupported cases.
.exclude("cast string to timestamp")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type in ansi mode")
enableSuite[GlutenArithmeticExpressionSuite]
enableSuite[GlutenBitwiseExpressionsSuite]
enableSuite[GlutenCastSuite]
Expand All @@ -121,8 +119,6 @@ class VeloxTestSettings extends BackendTestSettings {
// Revised by setting timezone through config and commented unsupported cases.
.exclude("cast string to timestamp")
.exclude("SPARK-36286: invalid string cast to timestamp")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type")
enableSuite[GlutenCollectionExpressionsSuite]
// Rewrite in Gluten to replace Seq with Array
.exclude("Shuffle")
Expand Down
4 changes: 0 additions & 4 deletions gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("cast from timestamp II")
.exclude("SPARK-36286: invalid string cast to timestamp")
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type")
enableSuite[GlutenTryCastSuite]
.exclude(
"Process Infinity, -Infinity, NaN in case insensitive manner" // +inf not supported in folly.
Expand All @@ -119,8 +117,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("cast string to timestamp")
// TODO: fix after https://github.com/facebookincubator/velox/pull/14910
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type in ansi mode")
enableSuite[GlutenCollectionExpressionsSuite]
// Rewrite in Gluten to replace Seq with Array
.exclude("Shuffle")
Expand Down
4 changes: 0 additions & 4 deletions gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("cast from timestamp II")
.exclude("SPARK-36286: invalid string cast to timestamp")
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type")
enableSuite[GlutenTryCastSuite]
.exclude(
"Process Infinity, -Infinity, NaN in case insensitive manner" // +inf not supported in folly.
Expand All @@ -123,8 +121,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("cast string to timestamp")
// TODO: fix after https://github.com/facebookincubator/velox/pull/14910
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type in ansi mode")
enableSuite[GlutenCollectionExpressionsSuite]
// Rewrite in Gluten to replace Seq with Array
.exclude("Shuffle")
Expand Down
4 changes: 0 additions & 4 deletions gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("cast from timestamp II")
.exclude("SPARK-36286: invalid string cast to timestamp")
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type")
enableSuite[GlutenTryCastSuite]
.exclude(
"Process Infinity, -Infinity, NaN in case insensitive manner" // +inf not supported in folly.
Expand All @@ -135,8 +133,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("cast string to timestamp")
// TODO: fix after https://github.com/facebookincubator/velox/pull/14910
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type in ansi mode")
enableSuite[GlutenCollectionExpressionsSuite]
// Rewrite in Gluten to replace Seq with Array
.exclude("Shuffle")
Expand Down
4 changes: 0 additions & 4 deletions gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("cast from timestamp II")
.exclude("SPARK-36286: invalid string cast to timestamp")
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type")
enableSuite[GlutenTryCastSuite]
.exclude(
"Process Infinity, -Infinity, NaN in case insensitive manner" // +inf not supported in folly.
Expand All @@ -139,8 +137,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("cast string to timestamp")
// TODO: fix after https://github.com/facebookincubator/velox/pull/14910
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type in ansi mode")
enableSuite[GlutenCollectionExpressionsSuite]
// Rewrite in Gluten to replace Seq with Array
.exclude("Shuffle")
Expand Down
Loading