[GLUTEN-12863][CH][TEST] Record why four ClickHouse exclusions exist on Spark 3.5 - #12889
[GLUTEN-12863][CH][TEST] Record why four ClickHouse exclusions exist on Spark 3.5#12889LuciferYang wants to merge 3 commits into
Conversation
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
There was a problem hiding this comment.
Pull request overview
This PR documents the rationale for four existing ClickHouse-specific test exclusions in the Spark 3.5 gluten-ut module, so future audits don’t require rerunning CI to rediscover the failures.
Changes:
- Add explanatory comments for the
tanhexclusion inGlutenMathExpressionsSuite. - Add explanatory comments for three TRY_CAST-related exclusions in
GlutenTryCastSuite(exception vs null, and overflow behavior inside complex types).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // ClickHouse's tanh differs from Spark's at the sixth significant digit: | ||
| // TANH(-0.1) returns -0.0996695958408681, the case expects -0.09966799462495582. |
|
Folding this into #12888 and closing here. The split made sense while this was an open question: it removed four ClickHouse exclusions to find out from CI whether they were still needed, and bundling an experiment with an unknown outcome into a PR that was ready to merge would have held that one up. The experiment is done, the ClickHouse CI failed all four, and what is left is eight lines of comments recording why. That is the same activity as #12888, on a file #12888 already modifies, so keeping them apart only buys a second review and a rebase for whichever lands second. The CI evidence and the resulting comments are carried over verbatim. |
ClickHouseTestSettingsingluten-ut/spark35excluded four cases with no comment saying why. This adds the reasons. The exclusions themselves are unchanged, so the net diff is eight comment lines.The reasons come from actually running them. All four are declared in Spark 3.3.1 and none of them is excluded in
gluten-ut/spark33, so they run on ClickHouse 3.3 today and would have lost their only run site when that module goes away under #12807;backends-clickhouse/pom.xmlhas profiles for 3.3 and 3.5 only. That made it worth finding out whether the 3.5 exclusions were still needed, so this PR first removed all four and let the ClickHouse CI answer. It failed all four:So the exclusions are right and only their reasons were missing.
cast from array IIIandcast from struct IIIare one behaviour: TRY-mode overflow inside a complex type wraps on ClickHouse instead of yielding null.tanhdiffers from Spark's result at the sixth significant digit.cast from array IIthrows rather than returning null.That also answers the question this started from: removing
gluten-ut/spark33does not lose ClickHouse coverage worth keeping here, because these four do not pass on 3.5 either. Whether ClickHouse should be fixed to match is a separate matter and out of scope; these comments just record what it does today so the next person auditing reason-less exclusions does not have to re-run CI to find out.Only
gluten-ut/spark35is touched. The same entries exist undergluten-ut/spark34,spark40andspark41, but no ClickHouse profile selects those modules.Tracked in #12863.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude claude-opus-5