Skip to content

[GOBBLIN-2262] Bump default thread counts for spec catalog listener and DAG processing engine #4189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaisyModi wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

[GOBBLIN-2262] Bump default thread counts for spec catalog listener and DAG processing engine #4189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gobblin-api/src/main/java/org/apache/gobblin/service/ServiceConfigKeys.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,9 @@ public class ServiceConfigKeys {
public static final String GOBBLIN_SERVICE_DAG_PROCESSING_ENGINE_PREFIX = ServiceConfigKeys.GOBBLIN_SERVICE_PREFIX + "dagProcessingEngine.";
public static final String NUM_DAG_PROC_THREADS_KEY = GOBBLIN_SERVICE_DAG_PROCESSING_ENGINE_PREFIX + "numThreads";
public static final String DAG_PROC_ENGINE_NON_RETRYABLE_EXCEPTIONS_KEY = GOBBLIN_SERVICE_DAG_PROCESSING_ENGINE_PREFIX + "nonRetryableExceptions";
public static final Integer DEFAULT_NUM_DAG_PROC_THREADS = 3;
public static final Integer DEFAULT_NUM_DAG_PROC_THREADS = 150;
Copy link
Copy Markdown
Contributor

@pratapaditya04 pratapaditya04 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this configurable?

public static final String NUM_SPEC_CATALOG_LISTENER_THREADS_KEY = GOBBLIN_SERVICE_PREFIX + "specCatalogListener.numThreads";
public static final int DEFAULT_NUM_SPEC_CATALOG_LISTENER_THREADS = 3;
public static final int DEFAULT_NUM_SPEC_CATALOG_LISTENER_THREADS = 150;
public static final long DEFAULT_FLOW_FINISH_DEADLINE_MILLIS = TimeUnit.HOURS.toMillis(24);

public static final String ERROR_PATTERN_STORE_CLASS = ServiceConfigKeys.GOBBLIN_SERVICE_PREFIX + "errorPatternStore.class";
Expand Down