Perf optimization -- debugging tracker latency#1028
Draft
elijahbenizzy wants to merge 4 commits intomainfrom
Draft
Perf optimization -- debugging tracker latency#1028elijahbenizzy wants to merge 4 commits intomainfrom
elijahbenizzy wants to merge 4 commits intomainfrom
Conversation
This is a proof of concept. What needs to be actually done: 1. ideally we expand/wrap the function with the dataloader type appropriately, to mirror the current process (I think that's what we want). I made them classes to make it easy to add from_X functions to create the metadata. Otherwise I don't type the metadata dictionaries -- so maybe we should do that / provide a way to push people to putting standard things in it. Otherwise I think this is more ergonomic for most people getting started.
They enable one to annotate a function as loading or saving data and then having that metadata available for capture. This also removes older code -- hopefully all of it...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--- PR TEMPLATE INSTRUCTIONS (1) ---
Looking to submit a Hamilton Dataflow to the sf-hamilton-contrib module? If so go the the
Previewtab and select the appropriate sub-template:Else, if not, please remove this block of text.
--- PR TEMPLATE INSTRUCTIONS (2) ---
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist