Skip to content

[alerter]bugfix: preserve group alert recovery events#4168

Open
hutiefang76 wants to merge 1 commit into
apache:masterfrom
hutiefang76:codex/fix-alarm-group-resolve
Open

[alerter]bugfix: preserve group alert recovery events#4168
hutiefang76 wants to merge 1 commit into
apache:masterfrom
hutiefang76:codex/fix-alarm-group-resolve

Conversation

@hutiefang76

Copy link
Copy Markdown

What's changed

Close #4160.

This fixes two group alert lifecycle cases:

  • do not let the firing repeat interval suppress pending resolved alerts in a mixed firing group
  • recompute the persisted group status from all known member alerts, so one recovered alert does not mark the whole group resolved while another member is still firing

Regression tests cover both the in-memory group reducer path and the database store path.

Verification

  • JAVA_HOME=$(/usr/libexec/java_home -v 25 2>/dev/null || /usr/libexec/java_home) ./mvnw -pl hertzbeat-alerter -am test
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Alarm group convergence: group wrongly flips to resolved and recovery events get silently dropped

1 participant