[feat] paginate the monitoring metrics data table - #4309
Open
orangeCatDeveloper wants to merge 1 commit into
Open
[feat] paginate the monitoring metrics data table#4309orangeCatDeveloper wants to merge 1 commit into
orangeCatDeveloper wants to merge 1 commit into
Conversation
A metric group with hundreds of rows rendered as one scroll blob in the detail card (apache#1594). Add front pagination with a size changer; page index resets on reload and page size change, and the scroll budget shrinks when the pager is visible so it is not clipped by the fixed-height card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Fixes #1594: a metric group with hundreds of rows renders as one unbounded scroll blob in the monitor detail card. The maintainer asked to "support pageable in monitoring metrics data table ui".
valueRowsinitialized to[](the new template expression evaluates before the async load); single-row table and fullscreen modal reuse the same template and keep workingBefore (200 rows, scroll only):
After (paged):
50/page (page index resets):
Checklist
Add or update API