HIVE-29664: Add syntax highlight support for beeline#6542
Open
aturoczy wants to merge 2 commits into
Open
Conversation
|
| static final Set<String> CONSTANTS = immutableUpper( | ||
| "TRUE", "FALSE", "NULL", "UNKNOWN"); | ||
|
|
||
| private static final String KEYWORD_LIST = |
Contributor
There was a problem hiding this comment.
Hi, my first though about the PR was a courosity if that way of listing the keywords and types duplicates an existing functionality or not so I consulted with @kasakrisz .
He gave a pointer about the existing parser functionality in HiveParser.
Is it possible to create a solution based on that one?
See:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To improve usability, Beeline should support basic Hive SQL syntax highlighting. The implementation can start with a static list of commonly used Hive SQL keywords, such as SELECT, INSERT, JOIN, WHERE, GROUP BY, ORDER BY, CREATE, DROP, ALTER, and others.
Why are the changes needed?
To improve the usability for beeline
Does this PR introduce any user-facing change?
yes, the default behavior is to highlight the syntax. It can be turn off, but in my mind it is better if it is on.
How was this patch tested?
Manually, and couple tests add for the parameter management.