HIVE-29656: q.out regex fix#6547
Open
illiabarbashov-sketch wants to merge 1 commit into
Open
Conversation
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests pending
tests unstable
labels
illiabarbashov-sketch
force-pushed
the
HIVE-29656-q_out_regex
branch
from
602f942 to
0a06c37
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
tests unstable
labels
illiabarbashov-sketch
force-pushed
the
HIVE-29656-q_out_regex
branch
from
0a06c37 to
0fa65cb
Compare
|
abstractdog
requested changes
Jun 19, 2026
abstractdog
left a comment
abstractdog
left a comment
Contributor
There was a problem hiding this comment.
patch looks good, we need to extend it for the currently existing (negative) q.outs
maybe having a look at those changes might make us more confident that this patch is correct
Comment on lines
+1025
to
+1026
| // This preserves backward compatibility with existing .q.out files that were written | ||
| // before the masking rules were introduced. |
Contributor
There was a problem hiding this comment.
I don't think we need backward compatibility: if the masking rules change, all the q.outs should change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?