Skip to content

HIVE-29787: Separate default JSON metrics file locations for HS2 and HMS to prevent overwriting #6666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aggarwal-Raghav wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

HIVE-29787: Separate default JSON metrics file locations for HS2 and HMS to prevent overwriting #6666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3649,10 +3649,10 @@ public static enum ConfVars {
"Deprecated, use HIVE_CODAHALE_METRICS_REPORTER_CLASSES instead. This configuration will be"
+ " overridden by HIVE_CODAHALE_METRICS_REPORTER_CLASSES if present. " +
"Comma separated list of JMX, CONSOLE, JSON_FILE, HADOOP2"),
HIVE_METRICS_JSON_FILE_LOCATION("hive.service.metrics.file.location", "/tmp/report.json",
HIVE_METRICS_JSON_FILE_LOCATION("hive.service.metrics.file.location", "/tmp/hs2-report.json",
"For metric class org.apache.hadoop.hive.common.metrics.metrics2.CodahaleMetrics JSON_FILE reporter, the location of local JSON metrics file. " +
"This file will get overwritten at every interval."),
HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", "5000ms",
HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", "60000ms",
new TimeValidator(TimeUnit.MILLISECONDS),
"For metric class org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " +
"the frequency of updating JSON metrics file."),
Expand Down
2 changes: 1 addition & 1 deletion ...e/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,7 +1229,7 @@ public enum ConfVars {
"hive.service.metrics.file.frequency", 60000, TimeUnit.MILLISECONDS,
"For json metric reporter, the frequency of updating JSON metrics file."),
METRICS_JSON_FILE_LOCATION("metastore.metrics.file.location",
"hive.service.metrics.file.location", "/tmp/report.json",
"hive.service.metrics.file.location", "/tmp/hms-report.json",
"For metric class json metric reporter, the location of local JSON metrics file. " +
"This file will get overwritten at every interval."),
METRICS_SLF4J_LOG_FREQUENCY_MINS("metastore.metrics.slf4j.frequency",
Expand Down
Loading