HIVE-29793: Packaging pom.xml docker profile passes flags and values as joined argv strings - #6671
Open
rubenada wants to merge 1 commit into
Open
HIVE-29793: Packaging pom.xml docker profile passes flags and values as joined argv strings#6671rubenada wants to merge 1 commit into
rubenada wants to merge 1 commit into
Conversation
…as joined argv strings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
packaging/pom.xmldocker profile passes flags and values as joined argv strings.Thus, when running
mvn ... -Pdocker, thebuild.shis invoked withargv[1]=="-hadoop 3.4.2"instead ofargv[1]=="-hadoop", argv[2]=="3.4.2", so the argument parser never matches its-hadoop/-tezcases and the build fails withError: -tez <Tez version> is required.Fix: split each
<argument>into flag and value pairs.Why are the changes needed?
Fix
Error: -tez <Tez version> is requiredwhen runningmvn ... -Pdocker.Does this PR introduce any user-facing change?
No.
How was this patch tested?
mvn clean install -DskipTests -Pdocker,dist