HTTPCLIENT-1482: expect-continue only on reused connections#683
Merged
Conversation
ok2c
approved these changes
Jul 20, 2025
Member
|
@arturobernalg It would be good to add tests to |
d2ac4c2 to
11865aa
Compare
… and modified RequestExpectContinue so that Expect: 100-continue is emitted only when the underlying connection has already processed at least one request; default behaviour (ALWAYS) preserved, API remains binary-compatible.
925bbc9 to
237b5f8
Compare
Member
Author
@ok2c my bad. I should have added tests Please take a look |
Member
|
@arturobernalg Looks good to me. |
arturobernalg
added a commit
to arturobernalg/httpcomponents-client
that referenced
this pull request
Oct 20, 2025
…tConfig, and modified RequestExpectContinue so that Expect: 100-continue is emitted only when the underlying connection has already processed at least one request; default behaviour (ALWAYS) preserved, API remains binary-compatible. (apache#683)" This reverts commit 97fd931.
arturobernalg
added a commit
to arturobernalg/httpcomponents-client
that referenced
this pull request
Oct 20, 2025
…tConfig, and modified RequestExpectContinue so that Expect: 100-continue is emitted only when the underlying connection has already processed at least one request; default behaviour (ALWAYS) preserved, API remains binary-compatible. (apache#683)" This reverts commit 97fd931.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces an opt-in strategy that limits automatic emission of the Expect: 100-continue header to requests executed over a reused (pooled) connection.
It eliminates “No response from server” ambiguity on non-idempotent requests without imposing the extra RTT on brand-new sockets.
Key points
The behaviour requested in Jira ticket HTTPCLIENT-1482 is now available to callers while keeping the classic client’s default semantics unchanged.