feat: implement RenameTable in InMemoryCatalog - #742
Merged
Conversation
Replace the NotImplemented stub with a full implementation that: - Returns early as a no-op when renaming a table to itself - Returns NoSuchTable when the source table does not exist - Returns AlreadyExists when the destination table already exists - Moves the metadata location from source to destination identifier Add unit test covering rename to self, nonexistent source, destination conflict, and full rename + load verification.
wgtmac
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the NotImplemented stub with a full implementation that:
Add unit test covering rename to self, nonexistent source, destination conflict, and full rename + load verification.