fix: validate transform parameters in metadata - #757
Merged
Conversation
huan233usc
approved these changes
Jun 30, 2026
huan233usc
left a comment
huan233usc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Correct and well-targeted: metadata validation now reaches the bind-time bucket/truncate parameter checks via Validate→Bind→Make, and the new tests genuinely exercise the parameter path (source types are valid for their transforms). Two minor, non-blocking nits inline.
| StringUtils::ParseNumber<int32_t>(match[2].str())); | ||
|
|
||
| if (type_str == kBucketName) { | ||
| if (param <= 0) { |
Contributor
There was a problem hiding this comment.
The bucket/truncate positivity rule (and its message) is now duplicated here and in BucketTransform::Make/TruncateTransform::Make. Fine for fail-fast on unbound transforms, but easy to drift — consider a shared helper if it grows.
fallintoplace
force-pushed
the
fix/validate-transform-params
branch
from
June 30, 2026 20:58
45d8d9d to
beb7824
Compare
wgtmac
approved these changes
Jul 11, 2026
Member
|
I went ahead to address all comments and now CIs are green. Let me merge this. Thanks @fallintoplace and @huan233usc! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transform::Validateto reuse bind-time transform checks during metadata validationValidation
cmake -S . -B build-transform-params -G Ninja -DICEBERG_BUILD_BUNDLE=OFF -DICEBERG_BUILD_REST=OFF -DICEBERG_BUILD_SHARED=OFFctest --test-dir build-transform-params -R schema_test --output-on-failure