Skip to content

feat: add ReplacePartitions core class (PR1 of 2 for #637) #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shangxinli wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: add ReplacePartitions core class (PR1 of 2 for #637) #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
12dc230
feat: add ReplacePartitions core class (PR1)
shangxinli Jun 24, 2026
90ae61d
address review: table-wide unpartitioned replace + ValidateDeletedDat…
Jun 24, 2026
c2a4a5f
address review: meson, Hive-compat note, reject no-data-files in Vali…
shangxinli Jun 25, 2026
d000927
fix: use AddFile flags to gate empty-replace check, not DataSpec()
shangxinli Jun 25, 2026
b03d790
Address review: void-transform unpartitioned check and DataSpec singl…
shangxinli Jul 11, 2026
52ef133
Merge branch 'main' into feat/replace-partitions-core
shangxinli Jul 11, 2026
638d2d4
Address wgtmac review: unconditional DataSpec, error translation, tests
shangxinli Jul 23, 2026
b971977
Merge remote-tracking branch 'upstream/main' into feat/replace-partit…
shangxinli Jul 23, 2026
8c71a01
Address wgtmac review: trim comments to contract, expand tests
shangxinli Jul 25, 2026
c9db9b7
test: strengthen ReplacePartitions assertions from second-pass review
shangxinli Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/iceberg/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ set(ICEBERG_SOURCES
update/expire_snapshots.cc
update/fast_append.cc
update/merge_append.cc
update/replace_partitions.cc
update/merging_snapshot_update.cc
update/overwrite_files.cc
update/pending_update.cc
Expand Down
1 change: 1 addition & 0 deletions src/iceberg/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ iceberg_sources = files(
'update/merging_snapshot_update.cc',
'update/overwrite_files.cc',
'update/pending_update.cc',
'update/replace_partitions.cc',
'update/rewrite_files.cc',
'update/row_delta.cc',
'update/set_snapshot.cc',
Expand Down
2 changes: 2 additions & 0 deletions src/iceberg/snapshot.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,8 @@ struct ICEBERG_EXPORT SnapshotSummaryFields {
inline static const std::string kEngineName = "engine-name";
/// \brief Version of the engine that created the snapshot
inline static const std::string kEngineVersion = "engine-version";
/// \brief Whether this is a replace-partitions operation
inline static const std::string kReplacePartitions = "replace-partitions";
};

/// \brief Helper class for building snapshot summaries.
Expand Down
3 changes: 2 additions & 1 deletion src/iceberg/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,8 @@ if(ICEBERG_BUILD_BUNDLE)
update_schema_test.cc
update_sort_order_test.cc
update_statistics_test.cc
overwrite_files_test.cc)
overwrite_files_test.cc
replace_partitions_test.cc)

add_iceberg_test(data_test
USE_BUNDLE
Expand Down
Loading
Loading