Skip to content

fix: reject malformed commit property integers - #843

Open
fallintoplace wants to merge 1 commit into
apache:mainfrom
fallintoplace:fix/reject-partial-commit-property-integers
Open

fix: reject malformed commit property integers#843
fallintoplace wants to merge 1 commit into
apache:mainfrom
fallintoplace:fix/reject-partial-commit-property-integers

Conversation

@fallintoplace

@fallintoplace fallintoplace commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • require commit property integers to parse completely, matching Java's Integer.parseInt
  • reject values with alphanumeric or decimal suffixes instead of accepting their numeric prefix
  • preserve the existing validation errors for invalid and out-of-range values

Testing

  • ctest --test-dir build -R ^table_test$ --output-on-failure
  • full CTest suite (17 test binaries)

@fallintoplace
fallintoplace force-pushed the fix/reject-partial-commit-property-integers branch from f881c81 to d30768c Compare July 25, 2026 15:28
@fallintoplace fallintoplace changed the title fix: reject partial commit property integers fix: reject trailing characters in commit properties Jul 25, 2026
@fallintoplace fallintoplace changed the title fix: reject trailing characters in commit properties fix: reject malformed commit property integers Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@evindj evindj evindj approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fallintoplace @evindj