fix: reject malformed Arrow field IDs - #845
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
evindj
reviewed
Jul 25, 2026
| int32_t GetFieldId(const ArrowSchema& schema) { | ||
| Result<int32_t> GetFieldId(const ArrowSchema& schema) { | ||
| if (schema.metadata == nullptr) { | ||
| return kUnknownFieldId; |
Contributor
There was a problem hiding this comment.
Should this be changed? It is not clear to me what is the difference between unknowFieldId (returning the constant) and InvalidFieldId (returning in a error)
Contributor
Author
There was a problem hiding this comment.
They are intentionally different. If the PARQUET:field_id metadata is missing, we keep the existing behavior and use the unknown field ID sentinel. If the key is present but the value is malformed or outside int32_t, we return an invalid schema error instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PARQUET:field_idmetadata instead of accepting a valid numeric prefix or returning the unknown-field sentinelTesting
arrow_test --gtest_filter=FromArrowSchemaTest.RejectMalformedFieldIdMetadata