fix: parse boolean properties case-insensitively - #847
Open
fallintoplace wants to merge 2 commits into
Open
Conversation
evindj
approved these changes
Jul 25, 2026
| return val; | ||
| } else if constexpr (std::is_same_v<U, bool>) { | ||
| return val == "true"; | ||
| return StringUtils::EqualsIgnoreCase(val, "true"); |
Contributor
There was a problem hiding this comment.
pretty sure you did but it would ne nice to check for other places in the code base where similar comparison with literals is made.
Contributor
Author
There was a problem hiding this comment.
Good call. I found the same case-sensitive parsing in the S3 properties and pushed a follow-up for s3.ssl.enabled and s3.path-style-access. The other literal comparisons I found are Avro schema attributes rather than configuration properties, so I left those unchanged.
zhjwpku
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Boolean.parseBooleantrueasfalseTesting
util_test --gtest_filter=ConfigTest.ParseBooleanIgnoringCase