fix: detect system Thrift in CONFIG mode - #855
Merged
Merged
Conversation
wgtmac
approved these changes
Jul 27, 2026
wgtmac
left a comment
Member
There was a problem hiding this comment.
Good catch! Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
REQUIRED_VARSdereferences its entries as variable names, so passing the targetthrift::thriftresolves to nothing and the module reports Thrift as missing. Instead we need to pass a variable holding the target.Why
The current behavior breaks
-DICEBERG_BUNDLE_THRIFT=OFFagainst any Thrift shipping a CMake config, which is 0.13 and later.resolve_thrift_dependency()callsfind_package(ThriftAlt MODULE REQUIRED), so the false negative aborts configure, and it is the pathiceberg_hiverecommends when the target is missing. It has gone unnoticed because Arrow's bundled Thrift defines the target first and the module returns early.Validation
Could NOT find ThriftAlt (missing: thrift::thrift)and configure aborts. After:Found ThriftAlt: thrift::thriftand configure completes.