Rest Catalog Support for a Separate OAuth Server URI#233
Merged
Fokko merged 2 commits intoapache:mainfrom Jan 16, 2024
Merged
Conversation
Fokko
reviewed
Jan 16, 2024
Fokko
approved these changes
Jan 16, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Let's move this forward, thanks @syun64 for working on this! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #230
This PR introduces support for Separation of Roles in OAuth authorization when using the REST Catalog, by allowing the user to use a distinct Authorization Server to fetch the access token and use it against the REST Catalog. In this scenario, the responsibility of the REST Catalog lies in validating the access token, instead of taking their secrets and deducing their identity and authorization.
This will allow PyIceberg to re-authorize the client using the stored credentials against the appropriate auth server if AuthorizationExpiredError is detected (Refreshing access_token is out of scope of this PR)