Conversation
| type=ListType( | ||
| element_id=2, | ||
| element_type=ListType( | ||
| element_id=3, |
There was a problem hiding this comment.
Out of curiosity, did you manually format the schema in this style or the make lint did the job? This looks nice, especially in case of multi-level nested schema 😄
There was a problem hiding this comment.
It was the linter :D I guess it got the inspiration from Java: https://github.com/apache/iceberg/blob/17757276928e87e78314b6c19c8b3ebad9612619/core/src/test/java/org/apache/iceberg/TestSchemaUnionByFieldName.java#L429-L459 :D
| else: | ||
| return self.new_schema.find_field(field_id).field_type | ||
|
|
||
| def field(self, field: NestedField, field_partner: Optional[int], field_result: bool) -> bool: |
There was a problem hiding this comment.
| def field(self, field: NestedField, field_partner: Optional[int], field_result: bool) -> bool: | |
| def field(self, field: NestedField, partner_id: Optional[int], field_result: bool) -> bool: |
Shall we name the second argument as partner_id to better reveal its content? We already did this in schema and struct. Same applied for *_partner arguments below
There was a problem hiding this comment.
I like it, thanks for the suggestion
|
Thanks for the review @HonahX |
2 participants
Resolves #284