Conversation
With the new Jetty upgrade in apache/iceberg#10837 we're running into the following: Failing CI: https://github.com/apache/iceberg-python/actions/runs/24416422109/job/71326697962 ```json Malformed request: { "message":"Suspicious Path Character", "url":"http://rest:8181/v1/namespaces/default%1Ftest_positional_mor_deletes_v2/tables/branch_without_5?snapshots=all", "status":"400" } ``` The `namespace-seperator` has been introduced afther the 1.10.x branch (apache#2826), so it isn't out in public, meaning the Spark integration tests are not respecting this config. This requires us to downgrade for now. I think disallowing the default (`%1F`) separator is problematic, since it might break compatibility.
|
Thanks for raising this Fokko! Looks like in the upgrade Jetty 12 is rejecting Pinning works but now maybe we should skip the WDYT @Fokko? |
@geruh In PyIceberg the separator is configurable: #2826 So we can reinstate the test again once 1.11.0 is out. I see that forgot to |
geruh
left a comment
There was a problem hiding this comment.
Awesome thanks for the fix Fokko!! I'll follow up to pin the SHAs mentioned by zizmor
With the new Jetty upgrade in apache/iceberg#10837 we're running into the following:
Failing CI: https://github.com/apache/iceberg-python/actions/runs/24416422109/job/71326697962
The
namespace-seperatorhas been introduced afther the 1.10.x branch (#2826), so it isn't out in public, meaning the Spark integration tests are not respecting this config. This requires us to downgrade for now.I think disallowing the default (
%1F) separator is problematic, since it might break compatibility.Rationale for this change
Are these changes tested?
Are there any user-facing changes?