Merged
Conversation
Fokko
approved these changes
Feb 10, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This is a big one, thanks for fixing this @danielcweeks
@syun64 We want to add this to the 0.6.0 as well
Fokko
reviewed
Feb 10, 2024
amogh-jahagirdar
approved these changes
Feb 10, 2024
Comment on lines
+397
to
+400
| except NoSuchObjectException as e: | ||
| raise NoSuchTableError(f"Table does not exist: {table_name}") from e | ||
| finally: | ||
| open_client.unlock(UnlockRequest(lockid=lock.lockid)) |
Contributor
There was a problem hiding this comment.
Don't consider this a blocker, but it'd be nice to have a test to verify that in case of any exception thrown we do actually perform the unlock.
Contributor
Author
There was a problem hiding this comment.
This is a really hard one because it requires that we've already acquired the lock, but then something happened (timeout?) and the the lock state changed. I'd have to think though how we could replicate that scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds locking to the hive commit path for tables. The current commit path is unsafe as competing updates may overwrite other clients that are using locking.
This implementation is the most restrictive in that it will fail a commit if it cannot immediately acquire a lock.