Merged
Conversation
HonahX
approved these changes
Feb 12, 2024
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
Just to confirm my understanding: after reverting this, do we need another PR to remove Hive and Thrift from the LICENSE?
Fokko
changed the title
LICENSE and NOTICE
Fokko
force-pushed
the
fd-revert-change
branch
2 times, most recently
from
01efa73 to
1ae4ea4
Compare
This reverts commit e9e265a.
Fokko
force-pushed
the
fd-revert-change
branch
from
1ae4ea4 to
ccadf50
Compare
Fokko
commented
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e9e265a.
If I'm reading the page right I don't think we should add this to the notice: