feat: Factor out CompressionCodec to common location and add Gzip#2081
Merged
liurenjie1024 merged 3 commits intoapache:mainfrom Jan 29, 2026
Merged
feat: Factor out CompressionCodec to common location and add Gzip#2081liurenjie1024 merged 3 commits intoapache:mainfrom
liurenjie1024 merged 3 commits intoapache:mainfrom
Conversation
1. Refactor compression to be top level so it can be used for other use cases. 2. Add GZIP encoder and consolidate existing Gzip code into framework.
emkornfield
changed the title
Contributor
Author
liurenjie1024
approved these changes
Jan 29, 2026
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @emkornfield for this pr, it looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
As discussed in the PR for allowing compressed metadata.json writes we want CompressionCodec in a central place so it can be used in puffin and for other compression use-cases. Happy to move it to
spec/as suggested in the original comment but this seemed more natural.What changes are included in this PR?
This moves compression.rs to a top level (seems like the best location for common code but please let me know if there is a better place.
Are these changes tested?
Added unit tests to cover additions and existing tests cover the rest.