Basic Integration with Datafusion#324
Merged
liurenjie1024 merged 37 commits intoapache:mainfrom May 2, 2024
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some fun, working with Datafusion and I want to share the (rough) design with you.
As outlined in #242 I went ahead and:
integrationsdatafusionwith its respective modules (catalog.rs, schema.rs, etc.)CatalogProviderThe overall structure should be extensible, meaning - if we want to support an integration with e.g.
polarswe simply create a new subfolder and implement the traits.The test infra is supposed to be used by every integration.
The IcebergCatalogProvider, for example, should be usable by any Catalog (since it Arc for the client (dynamic dispatch))
I really would appreciate your thoughts on this approach - so we can discuss how to proceed, whats missing upstream (like #277), etc.