Flink: Fix JdbcLockFactory to allow ClientPoolImpl connection retry (#15759)#16049
Open
yadavay-amzn wants to merge 1 commit intoapache:mainfrom
Open
Flink: Fix JdbcLockFactory to allow ClientPoolImpl connection retry (#15759)#16049yadavay-amzn wants to merge 1 commit intoapache:mainfrom
yadavay-amzn wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
JdbcLockFactory.JdbcLock, theinstanceId()andunlock()methods caughtSQLExceptioninside the lambda passed toClientPoolImpl.run()and wrapped it asUncheckedSQLException(aRuntimeException). This preventedClientPoolImpl's retry mechanism from triggering becauseisConnectionException()checks forSQLException, notUncheckedSQLException.Fix
Removed the inner
try-catchblocks that wrappedSQLExceptionasUncheckedSQLExceptioninside the lambdas. The lambda signature forClientPoolImpl.run()already declaresthrows Exception, soSQLExceptionpropagates naturally toClientPoolImplwhere the retry logic can detect connection exceptions and retry appropriately.The outer
catch (SQLException e)blocks remain to convert toUncheckedSQLExceptionafterClientPoolImplhas exhausted its retry attempts.Closes #15759