Fix RCK view tests failing with AlreadyExistsException due to missing ns1/ns2 in cleanup list#16050
Open
0xMALVEE wants to merge 1 commit intoapache:mainfrom
Open
Fix RCK view tests failing with AlreadyExistsException due to missing ns1/ns2 in cleanup list#160500xMALVEE wants to merge 1 commit intoapache:mainfrom
0xMALVEE wants to merge 1 commit intoapache:mainfrom
Conversation
ebyhr
reviewed
Apr 21, 2026
|
|
||
| static final List<Namespace> TEST_NAMESPACES = List.of(Namespace.of("ns"), Namespace.of("newdb")); | ||
| static final List<Namespace> TEST_NAMESPACES = | ||
| List.of(Namespace.of("ns"), Namespace.of("newdb"), Namespace.of("ns1"), Namespace.of("ns2")); |
Member
There was a problem hiding this comment.
nit: We could also add other_ns namespace created by renameViewUsingDifferentNamespace test.
ebyhr
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RESTCompatibilityKitViewCatalogTestsfails withAlreadyExistsExceptionon
createNamespacewhen view tests run sequentially. The@BeforeEachhook calls
RCKUtils.purgeCatalogTestEntriesto clean up between tests,but
TEST_NAMESPACESonly listednsandnewdb.ViewCatalogTests.listViews()createsns1andns2namespaces that werenever included in the purge list, so they accumulate across test methods.
Fix
Add
ns1andns2toRCKUtils.TEST_NAMESPACES.Testing
Run
RESTCompatibilityKitViewCatalogTeststo verify view tests no longerfail with
AlreadyExistsExceptiononcreateNamespace.