Skip to content

GCS, S3, ADLS: Handle EOF in inputStreams#16055

Open
vladislav-sidorovich wants to merge 5 commits intoapache:mainfrom
vladislav-sidorovich:bugs/gcs-handle-eof
Open

GCS, S3, ADLS: Handle EOF in inputStreams#16055
vladislav-sidorovich wants to merge 5 commits intoapache:mainfrom
vladislav-sidorovich:bugs/gcs-handle-eof

Conversation

@vladislav-sidorovich
Copy link
Copy Markdown
Contributor

@vladislav-sidorovich vladislav-sidorovich commented Apr 19, 2026

Returned EOF value was ignored and stale byte from singleByteBuffer was retuned in read().

In read(byte[] b, int off, int len) behavior was correct, only metrics and pos were affected.

@github-actions github-actions Bot added the GCP label Apr 19, 2026
Copy link
Copy Markdown
Contributor

@anoopj anoopj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks accurate to me. But the same bug exists in S3 and ADLS also. It would be worth calling out in the PR description.

Comment thread gcp/src/test/java/org/apache/iceberg/gcp/gcs/TestGCSInputStream.java Outdated
@anoopj
Copy link
Copy Markdown
Contributor

anoopj commented Apr 20, 2026

I filed #16062 to keep track of this general problem.

@vladislav-sidorovich
Copy link
Copy Markdown
Contributor Author

I filed #16062 to keep track of this general problem.

What do you think will be better PR per cloud storage or one PR for all of them?

@vladislav-sidorovich
Copy link
Copy Markdown
Contributor Author

I filed #16062 to keep track of this general problem.

What do you think will be better PR per cloud storage or one PR for all of them?

Well, it's not a lot of code... I will add S3 and ADLS here.

@vladislav-sidorovich vladislav-sidorovich changed the title GCS: Handle EOF in GCS inputStream GCS, S3, ADLS: Handle EOF in inputStreams Apr 20, 2026
@anoopj
Copy link
Copy Markdown
Contributor

anoopj commented Apr 21, 2026

I've pinged @nastra @danielcweeks @amogh-jahagirdar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants