Spark: Add unknown type support to Spark 3.4 and 3.5#16066
Open
Kurtiscwright wants to merge 3 commits intoapache:mainfrom
Open
Spark: Add unknown type support to Spark 3.4 and 3.5#16066Kurtiscwright wants to merge 3 commits intoapache:mainfrom
Kurtiscwright wants to merge 3 commits intoapache:mainfrom
Conversation
Map Iceberg's UnknownType to Spark's NullType in both directions: - TypeToSparkType: UNKNOWN -> NullType (Iceberg to Spark) - SparkTypeToType: NullType -> UnknownType (Spark to Iceberg) This aligns Spark 3.x with the existing Spark 4.x behavior and allows reading v3 tables with unknown-typed columns without throwing UnsupportedOperationException. Spark has supported NullType since 2.x.
Map Iceberg's UnknownType to Spark's NullType in both directions: - TypeToSparkType: UNKNOWN -> NullType (Iceberg to Spark) - SparkTypeToType: NullType -> UnknownType (Spark to Iceberg) This aligns Spark 3.x with the existing Spark 4.x behavior and allows reading v3 tables with unknown-typed columns without throwing UnsupportedOperationException. Spark has supported NullType since 2.x.
Contributor
|
This seems to be a backport of #13445. In that case we should backport this cleanly with all the tests as well |
Contributor
Author
Thank you for the review. I wasn't sure if backport was the correct framing in this instance, but its correct that its an extension of PR #13445. I will expand the PR to cover the same depth of unit tests as 13445 in a follow up commit along with fixing failing CI checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spark has supported null data types since 2.x. Current Iceberg implementation doesn't allow Unknown support in Spark 3.4 or 3.5. Adding support to allow usage of Unknown in Iceberg environments relaying on Spark 3.x (AWS EMR).