Detect contradictory predicates in Expressions.and() to enable scan p…#16071
Open
arthurli-dotcom wants to merge 1 commit intoapache:mainfrom
Open
Detect contradictory predicates in Expressions.and() to enable scan p…#16071arthurli-dotcom wants to merge 1 commit intoapache:mainfrom
arthurli-dotcom wants to merge 1 commit intoapache:mainfrom
Conversation
…runing
When Spark pushes predicates through UNION ALL views to Iceberg, contradictory
filters like `col = 'a' AND col != 'a'` can end up combined in a single scan.
Neither Spark's Catalyst optimizer nor Iceberg's expression system detected
these contradictions, causing Iceberg to plan tens of thousands of file tasks
that would return zero rows.
This adds contradiction detection to Expressions.and() for:
- EQ(col, a) AND NOT_EQ(col, a) with same value
- EQ(col, a) AND EQ(col, b) with different values
- EQ(col, val) AND NOT_IN(col, {val, ...})
- EQ(col, val) AND IN(col, set) where val not in set
- Contradictions through nested AND expressions
Handles both bound predicates (post-binding) and unbound predicates
(pre-binding, as used by SparkScanBuilder).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…runing
When Spark pushes predicates through UNION ALL views to Iceberg, contradictory filters like
col = 'a' AND col != 'a'can end up combined in a single scan. Neither Spark's Catalyst optimizer nor Iceberg's expression system detected these contradictions, causing Iceberg to plan tens of thousands of file tasks that would return zero rows.This adds contradiction detection to Expressions.and() for:
Handles both bound predicates (post-binding) and unbound predicates (pre-binding, as used by SparkScanBuilder).