Core: Fix incorrect manifest list projection causing unnecessary manifest scanning during snapshot expiration#16077
Open
hemanthboyina wants to merge 1 commit intoapache:mainfrom
Open
Conversation
…fest scanning during snapshot expiration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MANIFEST_PROJECTION in FileCleanupStrategy uses the V1 field name deleted_data_files_count instead of the correct deleted_files_count. Schema.select() drops the unrecognized name, leaving deletedFilesCount as null for all projected manifests. Since hasDeletedFiles() returns true when null, every manifest gets unnecessarily scanned during expireSnapshots cleanup.