API, Core: add support for new property, write.parquet.format-version#16763
Open
The-Alchemist wants to merge 1 commit into
Open
API, Core: add support for new property, write.parquet.format-version#16763The-Alchemist wants to merge 1 commit into
The-Alchemist wants to merge 1 commit into
Conversation
The-Alchemist
changed the title
The-Alchemist
force-pushed
the
feature/added-config-for-parquet-format-version
branch
from
df02a96 to
815f6b1
Compare
…sion Added write.parquet.format-version (v1 or v2) to control Parquet writer output. write.parquet.page-version still applies when format-version isn't set. Both properties share the same v1/v2 parsing. Wire it through Spark and Flink write configs; delete files inherit data-file settings unless overridden. Signed-off-by: Karl Pietrzak <karl@medplum.com>
The-Alchemist
force-pushed
the
feature/added-config-for-parquet-format-version
branch
from
815f6b1 to
5c1e30a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
write.parquet.format-version(v1 or v2) to control Parquet writer output.write.parquet.page-versionstill applies when format-version isn't set. Both properties share the same v1/v2 parsing. Wired it through Spark and Flink write configs. Almost entirely a pass-through.Open question: do we need
write.delete.parquet.format-versionandwrite.delete.parquet.page-version? They follow the same pattern aswrite.delete.parquet.compression-codecbut I'm not sure how often anyone will tune delete files separately from data files. Also raises the issue of incompatibilities between format versions and page versions.