Core: Introduce builder for TrackedFile#16769
Open
gaborkaszab wants to merge 1 commit into
Open
Conversation
pvary
reviewed
Jun 11, 2026
| file.set(10, dv); | ||
| file.set(12, ByteBuffer.wrap(new byte[] {1, 2, 3})); | ||
| file.set(13, ImmutableList.of(50L)); | ||
| (TrackedFileStruct) |
Contributor
There was a problem hiding this comment.
Are we sure that we want to test the struct through the builder?
Contributor
Author
There was a problem hiding this comment.
This function is not relevant for testing the "struct-ness" of the class, this creates an input object with certain fields for the various tests. Note, some members are already populated through the constructor and not setters. Note, there is a dedicated test testFieldAccess that exercises the setter functions for all the fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.