Skip to content

Core: Fix flaky TestHadoopCommits.testConcurrentFastAppends #16770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wombatu-kun wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Core: Fix flaky TestHadoopCommits.testConcurrentFastAppends #16770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,8 +426,10 @@ public void testConcurrentFastAppends(@TempDir File dir) throws Exception {
SCHEMA,
SPEC,
ImmutableMap.of(
// Use a high retry count so no committer exhausts its retries under the forced
// lock-step contention below (matches Test{Jdbc,Hive}TableConcurrency).
COMMIT_NUM_RETRIES,
String.valueOf(threadsCount),
"20",

@singhpk234 singhpk234 Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 20 ?

@wombatu-kun wombatu-kun Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because two sibling optimistic-commit concurrency tests TestJdbcTableConcurrency and TestHiveTableConcurrency both use 20 retries, and it looks like it's enough avoid flakiness this way.

COMMIT_MIN_RETRY_WAIT_MS,
"10",
COMMIT_MAX_RETRY_WAIT_MS,
Expand Down