Azure: Honor init-creation-stacktrace in ADLS input and output streams#16786
Open
wombatu-kun wants to merge 1 commit into
Open
Azure: Honor init-creation-stacktrace in ADLS input and output streams#16786wombatu-kun wants to merge 1 commit into
wombatu-kun wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADLSInputStream and ADLSOutputStream capture a full thread stack trace (Thread.currentThread().getStackTrace()) in their constructors. The stack is only used by finalize() to report the creation site when a stream is garbage collected without being closed, but the capture runs on every stream creation, i.e. on the per-file read/write path.
ResolvingFileIO already records the creation stack of the FileIO it delegates to, and tells the delegate to skip its own capture by setting init-creation-stacktrace=false in the delegate's properties. ADLSFileIO did not honor that flag, so every ADLS stream re-captured a stack trace even though ResolvingFileIO had already recorded one.
This makes the ADLS streams honor init-creation-stacktrace (default true), read through AzureProperties, exactly as #16739 does for the S3 input and output streams. The problem and the fix are identical to #16739; that PR contains the JMH benchmarks quantifying the per-stream allocation saved by skipping the capture. When the capture is disabled, finalize() still logs an unclosed-stream warning and points to the property to re-enable the creation stack.
Tests: TestAzureProperties covers the default, the explicit-disable value that ResolvingFileIO relies on, and that the setting survives serialization.