Skip to content

fix: apply S3 service configurations to async S3 client (#14575) #17549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

fix: apply S3 service configurations to async S3 client (#14575) #17549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4d205f
fix: broaden applyServiceConfigurations to accept S3BaseClientBuilder…
waterWang Aug 7, 2026
11f8419
fix: apply S3 service configurations to async S3 client (#14575)
waterWang Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ public S3AsyncClient s3Async() {
.applyMutation(
b -> s3FileIOProperties.applyCredentialConfigurations(awsClientProperties, b))
.applyMutation(s3FileIOProperties::applyEndpointConfigurations)
.applyMutation(s3FileIOProperties::applyServiceConfigurations)
.build();
}

Expand Down
2 changes: 1 addition & 1 deletion aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,10 +1006,10 @@
* S3Client.builder().applyMutation(s3FileIOProperties::applyS3ServiceConfigurations)
* </pre>
*/
public <T extends S3ClientBuilder> void applyServiceConfigurations(T builder) {
public <T extends S3BaseClientBuilder> void applyServiceConfigurations(T builder) {
builder
.dualstackEnabled(isDualStackEnabled)
.crossRegionAccessEnabled(isCrossRegionAccessEnabled)

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / spark-runtime-3.5_2.12 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / flink-runtime-1.20 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / spark-runtime-4.1_2.13 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / flink-runtime-2.0 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / build-javadoc (17, pull_request) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / flink-runtime-2.1 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / spark-runtime-4.0_2.13 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / build-checks (17, pull_request) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / check-runtime-deps 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / kafka-connect-runtime 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / kafka-connect-tests (17, pull_request) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / spark-tests (17, pull_request, 3.5, 2.13, core) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / spark-tests (17, pull_request, 3.5, 2.12, core) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / flink-scala-2-12-tests (17, pull_request, 1.20) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / open-api-test-fixtures-runtime 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / spark-tests (17, pull_request, 4.1, 2.13, core) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / spark-tests (17, pull_request, 3.5, 2.13, extensions) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / spark-tests (17, pull_request, 4.0, 2.13, extensions) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / spark-tests (17, pull_request, 4.1, 2.13, extensions) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / spark-tests (17, pull_request, 4.0, 2.13, core) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / core-tests (17, pull_request) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / flink-scala-2-12-tests (17, pull_request, 2.0) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / spark-tests (17, pull_request, 3.5, 2.12, extensions) 

cannot find symbol

Check failure on line 1012 in aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java

View workflow job for this annotation

GitHub Actions / flink-scala-2-12-tests (17, pull_request, 2.1) 

cannot find symbol
.serviceConfiguration(
S3Configuration.builder()
.pathStyleAccessEnabled(isPathStyleAccess)
Expand Down
Loading