-
Notifications
You must be signed in to change notification settings - Fork 245
feat(server): implement log rotation based on size and retention #2452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Svecco
wants to merge
1
commit into
apache:master
Choose a base branch
from
Svecco:46-size-logs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+594
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think changes in |
Svecco
added a commit
to Svecco/iggy
that referenced
this pull request
Dec 13, 2025
…retention - Configurable maximum log size and retention period from server configuration - Optimized single directory traversal for collecting file information - Eliminated redundant metadata() calls for improved performance - Enhanced error handling with detailed logging for all failure cases - Merged directory traversals into a single operation to improve performance Fixes apache#46, detail changes can be found at apache#2452.
Author
Yes, that was the case. I have just rebased it to the correct state. |
Author
|
Result of running Terminal |
spetz
reviewed
Dec 14, 2025
spetz
reviewed
Dec 14, 2025
spetz
reviewed
Dec 14, 2025
spetz
reviewed
Dec 14, 2025
spetz
reviewed
Dec 14, 2025
spetz
reviewed
Dec 14, 2025
spetz
reviewed
Dec 14, 2025
hubcio
reviewed
Dec 15, 2025
Svecco
added a commit
to Svecco/iggy
that referenced
this pull request
Dec 20, 2025
…retention - Configurable maximum log size and retention period from server configuration - Optimized single directory traversal for collecting file information - Eliminated redundant metadata() calls for improved performance - Enhanced error handling with detailed logging for all failure cases - Merged directory traversals into a single operation to improve performance Fixes apache#46, detail changes can be found at apache#2452.
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirected from issue #46 , the progress:
_install_log_rotation_handlerfunction, which was previously marked astodo;cleanup_log_filesto delete logs based on the configured time threshold & size;metadata()calls by collecting data in single traversal;Before merge:
Plan:
Around the next several weekends.