feat(node): drop classic framing and test only against the VSR server - #3843
Merged
Conversation
hubcio
force-pushed
the
ci/node-vsr-only
branch
from
August 7, 2026 22:21
f0f1ca3 to
e2fa40a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3843 +/- ##
============================================
- Coverage 76.97% 75.91% -1.07%
- Complexity 1021 1316 +295
============================================
Files 1366 1378 +12
Lines 176208 177075 +867
Branches 146138 146315 +177
============================================
- Hits 135639 134423 -1216
- Misses 36695 38689 +1994
- Partials 3874 3963 +89
🚀 New features to boost your workflow:
|
The Node SDK carried a dual wire stack: legacy 8-byte framing plus the VSR consensus framing, selected by a protocol config option. Every classic path was dead weight once server-ng became the CI target, and the option let clients silently pick a framing the server does not speak. Remove the classic protocol entirely: the SDK now always frames requests for VSR, so the protocol option, the classic encoder and response parser, and the per-protocol frame decoder branches are gone. All node CI lanes (e2e, coverage, BDD, examples) start a single iggy-server-ng built with --features vsr; the separate e2e-vsr lane is folded into e2e. The tcp-tls example switches from Balanced to explicit PartitionId partitioning because the VSR client routes each send to a partition-scoped namespace and rejects broker-side balancing before the request is sent. Breaking npm API change, hence the 0.10.0-edge.1 bump. The stale pre-monorepo CHANGELOG is removed.
hubcio
force-pushed
the
ci/node-vsr-only
branch
from
August 10, 2026 14:14
e2fa40a to
4d6dc84
Compare
mmodzelewski
approved these changes
Aug 10, 2026
spetz
approved these changes
Aug 10, 2026
thepatrykk
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node SDK carried a dual wire stack: legacy 8-byte framing plus
the VSR consensus framing, selected by a protocol config option.
Every classic path was dead weight once server-ng became the CI
target, and the option let clients silently pick a framing the
server does not speak.
Remove the classic protocol entirely: the SDK now always frames
requests for VSR, so the protocol option, the classic encoder and
response parser, and the per-protocol frame decoder branches are
gone. All node CI lanes (e2e, coverage, BDD, examples) start a
single iggy-server-ng built with --features vsr; the separate
e2e-vsr lane is folded into e2e. The tcp-tls example switches from
Balanced to explicit PartitionId partitioning because the VSR
client routes each send to a partition-scoped namespace and
rejects broker-side balancing before the request is sent.
Breaking npm API change, hence the 0.10.0-edge.1 bump. The stale
pre-monorepo CHANGELOG is removed.