Skip to content

fix(server-ng): skip NUMA memory binding on non-Linux platforms - #3850

Open
ethanlin01x wants to merge 1 commit into
apache:masterfrom
ethanlin01x:fix/macos-numa-memory-binding
Open

fix(server-ng): skip NUMA memory binding on non-Linux platforms#3850
ethanlin01x wants to merge 1 commit into
apache:masterfrom
ethanlin01x:fix/macos-numa-memory-binding

Conversation

@ethanlin01x

@ethanlin01x ethanlin01x commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR address?

Closes #3849

Rationale

iggy-server-ng cannot start on macOS at all

What changed?

ShardInfo::bind_memory binds each shard's memory to its NUMA node via hwloc. hwloc has no memory-binding backend for macOS, so the call returns Unsupported and MemoryBindingFlags::STRICT turns that into a hard error, killing every shard thread during bootstrap.

The bind is now gated on Linux the way its sibling bind_cpu already is.

Local Execution

  • Passed
  • Pre-commit hooks ran

AI Usage

  1. Which tools? Claude Code
  2. Scope of usage? Diagnosis
  3. How did you verify the generated code works correctly? Ran iggy-server-ng on Apple Silicon macOS
  4. Can you explain every line of the code if asked? Yes

@ethanlin01x
ethanlin01x force-pushed the fix/macos-numa-memory-binding branch from c8b0b43 to cfd00d6 Compare August 9, 2026 11:08
@ethanlin01x
ethanlin01x marked this pull request as ready for review August 9, 2026 11:10
@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 9, 2026
@ethanlin01x

Copy link
Copy Markdown
Contributor Author

/request-review @hubcio

@github-actions
github-actions Bot requested a review from hubcio August 9, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iggy-server-ng fails to boot on macOS: NUMA memory binding is unsupported

1 participant