Skip to content

MSSQL Source Connector - #3851

Draft
lsabi wants to merge 7 commits into
apache:masterfrom
lsabi:lsabi/mssql-source
Draft

MSSQL Source Connector#3851
lsabi wants to merge 7 commits into
apache:masterfrom
lsabi:lsabi/mssql-source

Conversation

@lsabi

@lsabi lsabi commented Aug 9, 2026

Copy link
Copy Markdown

Which issue does this PR address?

Partially Closes # #3573
Relates to #

Rationale

This is just the implementation of the source connector for the cdc. I'm also working on the table polling, but it'll require more time.

I don't have a database instance to test it, but tests are passing. If someone, who has a test MSSQL instance can try it out, it would be great.

What changed?

Added the

Local Execution

  • Unit Tests pass. Not tested with a real database instance, as I don't have an instance with dummy data to ruin (only production)
  • Pre-commit hooks not ran

AI Usage

None

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Thanks for the PR. It is labeled S-waiting-on-review and queued for review.

Slash commands (own line, regular comment) move it around the queue:

  • /ready - back to S-waiting-on-review after addressing feedback
  • /author - flip to S-waiting-on-author while you finish changes
  • /request-review @user-or-team - request a reviewer

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 9, 2026
@lukaszzborek

lukaszzborek commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

@lsabi please make this pr as draft or close it and add test, then reopen
there is docker image microsoft/mssql-server which you can use

@lukaszzborek lukaszzborek added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Aug 9, 2026
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.10%. Comparing base (01a64b2) to head (3c54da0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3851      +/-   ##
============================================
- Coverage     76.58%   74.10%   -2.48%     
  Complexity     1046     1046              
============================================
  Files          1347     1345       -2     
  Lines        171018   170768     -250     
  Branches     142372   142389      +17     
============================================
- Hits         130967   126547    -4420     
- Misses        36233    40534    +4301     
+ Partials       3818     3687     -131     
Components Coverage Δ
Rust Core 75.78% <ø> (ø)
Java SDK 63.67% <ø> (ø)
C# SDK 33.11% <ø> (-39.17%) ⬇️
Python SDK 88.70% <ø> (ø)
PHP SDK 82.97% <ø> (ø)
Node SDK 89.68% <ø> (-6.61%) ⬇️
Go SDK 53.01% <ø> (-16.17%) ⬇️
see 162 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lsabi
lsabi marked this pull request as draft August 10, 2026 12:06
@github-actions github-actions Bot removed the S-waiting-on-author PR is waiting on author response label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants