fix(rust): add heartbeat handle and drop for rust sdk - #3852
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3852 +/- ##
=============================================
- Coverage 76.76% 52.10% -24.67%
- Complexity 1021 1316 +295
=============================================
Files 1365 1376 +11
Lines 172679 152834 -19845
Branches 142608 121965 -20643
=============================================
- Hits 132559 79630 -52929
- Misses 36300 70013 +33713
+ Partials 3820 3191 -629
🚀 New features to boost your workflow:
|
thepatrykk
approved these changes
Aug 10, 2026
numinnex
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Relates to #3733 (comment)
Rationale
The heartbeat handle was being discarded and on shutdown, not being stopped on calling
shutdown.What changed?
Adds a heartbeat_handler that is saved when
connect()is called. In case connect is called repeatedly, the code uses the handler, and drops it when the client is destroyed.Local Execution
AI Usage
If AI tools were used, please answer: