Skip to content

[WIP] Move read methods to binary-impl - #13636

Open
nizhikov wants to merge 37 commits into
apache:masterfrom
nizhikov:move4
Open

nizhikov wants to merge 37 commits into
apache:masterfrom
nizhikov:move4

Conversation

@nizhikov

@nizhikov nizhikov commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see tab PR Check at TC.Bot - Instance 1 or TC.Bot - Instance 2)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

nizhikov and others added 30 commits September 24, 2026 12:29
…, writeFieldId from BinaryWriterEx

These methods are used only by BinaryObjectBuilderImpl in binary-impl.
The builder now works with BinaryWriterExImpl directly, so the methods
live on the implementation only. BinaryWriterExImpl is made public so
the builder package can reference it; newWriter() gets a covariant
return type.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Used only by BinaryBuilderSerializer in binary-impl, which already
works with BinaryWriterExImpl.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Used only by BinaryPlainBinaryObject in binary-impl, which already
works with BinaryWriterExImpl.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant