Skip to content

IGNITE-29232 Fix continuous query backup ack not sent to all backups - #13773

Open
wernerdv wants to merge 1 commit into
apache:masterfrom
wernerdv:IGNITE-29232
Open

wernerdv wants to merge 1 commit into
apache:masterfrom
wernerdv:IGNITE-29232

Conversation

@wernerdv

Copy link
Copy Markdown
Contributor

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see tab PR Check at TC.Bot - Instance 1 or TC.Bot - Instance 2)

Notes

If you need any help, please email dev@ignite.apache.org or ask any advice on https://the-asf.slack.com #ignite channel.

@wernerdv wernerdv changed the title IGNITE-29232 Fix continuous query backup ack sent to single node IGNITE-29232 Fix continuous query backup ack not sent to all backups Oct 30, 2026
@github-actions

Copy link
Copy Markdown

Possible compatibility issues. Please, check rolling upgrade cases

This PR modifies protected classes (with Order annotation).
Changes to these classes can break rolling upgrade compatibility.

Affected files:

  • modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryHandler.java

@wernerdv
wernerdv requested a balanced review from Copilot October 30, 2026 13:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

3 open issues
What changed in this PR

Fixes an issue where continuous query backup acknowledgements spanning multiple topology versions were not sent to all backup nodes.

Changes:

  • Adjusted backup-ack send de-duplication to key by the actual destination node ID.
  • Added a regression test that forces an acknowledgement to cover multiple topology versions (topology change mid-stream).
File Description
modules/​core/​src/​main/​java/​org/​apache/​ignite/​internal/​processors/​cache/​query/​continuous/​CacheContinuousQueryHandler.java Fixes per-node “already sent” tracking when sending backup acknowledgements across topology versions.
modules/​core/​src/​test/​java/​org/​apache/​ignite/​internal/​processors/​continuous/​ContinuousQueryBuffersCleanupTest.java Adds a regression test reproducing the multi-topology-version backup-ack scenario and asserting CQ buffers are eventually cleared.

Review effort: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants