Update dummy.yml and remove gradle/wrapper-validation-action from approval#586
Closed
Update dummy.yml and remove gradle/wrapper-validation-action from approval#586
dummy.yml and remove gradle/wrapper-validation-action from approval#586Conversation
wrapper-validation-action uses another action by tag Signed-off-by: Dave Fisher <dave2wave@comcast.net>
Signed-off-by: Dave Fisher <dave2wave@comcast.net>
dave2wave
changed the title
dave2wave
changed the title
dummy.yml and remove grade/wrapper-validation-action from approval
dave2wave
changed the title
dummy.yml and remove grade/wrapper-validation-action from approvaldummy.yml and remove gradle/wrapper-validation-action from approval
Member
|
I see (https://github.com/gradle/wrapper-validation-action/blob/main/action.yml#L29). This is used by a couple of actions: might be nice to see if upstream would be open to a PR pinning it to a hash? |
raboof
approved these changes
Mar 26, 2026
Member
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
ah it's archived, and recommends people should be using uses: gradle/actions/wrapper-validation@v3 instead. Seems fine to drop it then I think?
Member
|
now merged as #601 |
Member
Author
|
The trouble is that some yet unknown number of previously approved composite actions need to disapproved due to using actions via tag not sha. This PR was a start to a slow incremental process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrapper-validation-action uses another action by tag