Skip to content

Fix dependabot cooldown config: use default-days and increase to 7#607

Open
kevinjqliu wants to merge 1 commit intoapache:mainfrom
kevinjqliu:kevinjqliu/cooldown
Open

Fix dependabot cooldown config: use default-days and increase to 7#607
kevinjqliu wants to merge 1 commit intoapache:mainfrom
kevinjqliu:kevinjqliu/cooldown

Conversation

@kevinjqliu
Copy link
Contributor

Follow up to ##560

Changes

  • Fix cooldown key name: defaultdefault-days per the GitHub docs
  • Increase cooldown period: 4 → 7 days, as recommended by zizmor
  • Update README to reflect both fixes in the documentation and example snippet

Why

The previous config used default, which is not a valid key under cooldown. The correct key is default-days. Additionally, zizmor recommends a 7-day cooldown to allow new releases to stabilize before Dependabot proposes updates.

- Fix key name from 'default' to 'default-days' per GitHub docs
- Increase cooldown period from 4 to 7 days as recommended by zizmor
- Update README to reflect the corrected key name and new value

See: https://docs.zizmor.sh/audits/\#dependabot-cooldown
@kevinjqliu
Copy link
Contributor Author

cc @potiuk

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually prefer not to have a cooldown period in this repository, because this dependabot workflow is also used for triggering reviews of updates to allowlisted GitHub Actions in dummy.yml. The quicker we can start reviewing the better, and these workflows are not actually ran, so there's no risk. Of course actual projects may still apply a cooldown period. Having no cooldown period here will also reduce the risk that a GHA gets merged into a project before it gets reviewed and allowlisted here.

(sorry I missed #560)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants