Skip to content

[INLONG-12197][SDK] Make batch done idempotent in Dataproxy Go SDK #12204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yfsn666 wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

[INLONG-12197][SDK] Make batch done idempotent in Dataproxy Go SDK #12204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/dataproxy/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ func (h heartbeatReq) encode(buffer *bytes.Buffer) []byte {
type batchCallback func()
type batchReq struct {
pool *sync.Pool
finished bool
workerID string
batchID string
groupID string
Expand All @@ -111,6 +112,13 @@ func (b *batchReq) append(req *sendDataReq) {
}

func (b *batchReq) done(err error) {
// Idempotency guard: if the batch has already been done, return immediately
// to avoid releasing resources or invoking callbacks more than once.
if b.finished {
return
}
b.finished = true

errorCode := getErrorCode(err)
for i, req := range b.dataReqs {
req.done(err, errorCode)
Expand Down
Loading