[INLONG-12200][SDK] Avoid calling the handler while holding the lock to prevent reentrant deadlock in Dataproxy Go SDK - #12207
Open
yfsn666 wants to merge 1 commit into
Open
[INLONG-12200][SDK] Avoid calling the handler while holding the lock to prevent reentrant deadlock in Dataproxy Go SDK#12207yfsn666 wants to merge 1 commit into
yfsn666 wants to merge 1 commit into
Conversation
…to prevent reentrant deadlock in Dataproxy Go SDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12200
Motivation
In the Dataproxy Go SDK, if an OnEndpointUpdate handler calls back into AddEventHandler/DelEventHandler/GetEndpoints from within the Manager-based or DNS discoverer's lookup, the same goroutine re-enters the discoverer's RWMutex and deadlocks.
Modifications
In both the Manager-based discoverer (
dataproxy/discoverer.go) and the DNS discoverer (discoverer/dns.go), copy the handler list while holding the read lock, release the lock, and only then invoke theOnEndpointUpdatecallbacks.Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation