Skip to content

Fixed the bug that create attribute does not consider nameList size > valueList size #17593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Caideyipi wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −0
Open

Fixed the bug that create attribute does not consider nameList size > valueList size #17593

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e78316e
fix
Caideyipi May 1, 2026
080602a
Update DeviceAttributeStore.java
Caideyipi May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...in/java/org/apache/iotdb/db/schemaengine/schemaregion/attribute/DeviceAttributeStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,10 @@
// todo implement storage for device of diverse data types
long memUsage = MAP_SIZE + RamUsageEstimator.NUM_BYTES_OBJECT_REF;
final Map<String, Binary> attributeMap = new HashMap<>();
for (int i = 0; i < nameList.size(); i++) {

Check warning on line 140 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/attribute/DeviceAttributeStore.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 


See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ3i3KtWxTbyeZtnd-Q0&open=AZ3i3KtWxTbyeZtnd-Q0&pullRequest=17593
if (valueList.length <= i) {
break;
}
if (valueList[i] == null || valueList[i] == Constants.NONE) {
continue;
}
Expand Down
Loading