Skip to content

Fix line endings in c14n test files for n-triples and n-quads#3848

Closed
utafrali wants to merge 1 commit intoapache:mainfrom
utafrali:fix/issue-3845-canonicalization-tests-n-triples-and-n-q
Closed

Fix line endings in c14n test files for n-triples and n-quads#3848
utafrali wants to merge 1 commit intoapache:mainfrom
utafrali:fix/issue-3845-canonicalization-tests-n-triples-and-n-q

Conversation

@utafrali
Copy link
Copy Markdown

@utafrali utafrali commented Apr 8, 2026

GitHub issue resolved #3845

Pull request Description:

The canonicalization tests for n-triples and n-quads were failing on Windows due to line ending inconsistencies. Git was normalizing line endings differently across platforms, which caused the test comparisons to fail.

This adds .gitattributes entries to enforce text eol=lf for the canonicalization test files in both rdf12/rdf-n-triples/c14n/ and rdf12/rdf-n-quads/c14n/, matching the pattern already used for other test files in the repo.

Tests pass locally on both platforms after the change.


  • Tests are included.
  • Documentation change and updates are provided for the Apache Jena website.
  • Commits have been squashed to remove intermediate development commit messages.
  • Key commit messages start with the issue number (GH-xxxx)

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.

@afs
Copy link
Copy Markdown
Member

afs commented Apr 9, 2026

Hi @utafrali,

Thank you very much. THis shows that there is another problem in this aera. The .gitattributes file was out-of-date in other ways. Files had been deleted to consistently use the official test versions.

Nowadays rdf-testing/RIOT/test-cg is an untouched copy of the official tests - we can update easily by delete-copy. Any local tweaking, if needed, happens in the test manifest processors (their aren't any tweaks for RDF syntax tests).

#3849 removes the jena-arq.gitattributes and updates the jena-arq/testing/rdf-tests-cg/rdf/.gitattributes‎ one
by copying it from rdf-tests - this also picks up an updated test - material from w3c/rdf-tests#316.

(And for anyone digging into the details - the rdf-tests-cg RDF/XML tests will have to change at sometime.)

@afs afs closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Canonicalization tests - N-triples and N-Quads --> fails - most likely it only fails on windows

2 participants