fix(tooling): support non-standard feature classifier names in karaf-maven-plugin (#2144)#2310
Open
jbonofre wants to merge 1 commit intoapache:mainfrom
Open
fix(tooling): support non-standard feature classifier names in karaf-maven-plugin (#2144)#2310jbonofre wants to merge 1 commit intoapache:mainfrom
jbonofre wants to merge 1 commit intoapache:mainfrom
Conversation
…maven-plugin (apache#2144) The feature descriptor generator hardcoded the "features" classifier, causing dependencies with non-standard classifiers (e.g. "features-core") to be inlined as bundles instead of recognized as feature dependencies. - Dependency31Helper.isFeature(): match classifiers starting with "features" - GenerateDescriptorMojo.processFeatureArtifact(): remove redundant classifier check - GenerateDescriptorMojo: use configured attachmentArtifactClassifier instead of hardcoded FEATURE_CLASSIFIER when setting the project artifact - AssemblyMojo.getType() and RunMojo.getAttachedFeatureFile(): same classifier fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature descriptor generator hardcoded the "features" classifier, causing dependencies with non-standard classifiers (e.g. "features-core") to be inlined as bundles instead of recognized as feature dependencies.